Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Event::MouseMoved to Event::MouseMove #825

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Rename Event::MouseMoved to Event::MouseMove #825

merged 2 commits into from
Apr 10, 2020

Conversation

teddemunnik
Copy link
Contributor

As discussed in #821, this renames MouseMoved to MouseMove for consistency with web API's.

xStrom
xStrom reviewed Apr 10, 2020
View reviewed changes
druid/src/contexts.rs Outdated
/// event handler, but can also be called in response to other events,
/// for example pressing a key to change the behavior of a widget.
///
/// [`MouseMoved`]: enum.Event.html#variant.MouseDown
/// [`MouseMove`]: enum.Event.html#variant.MouseDown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this link to enum.Event.html#variant.MouseMove while we're here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed :)

@cmyr
Copy link
Member

cmyr commented Apr 10, 2020

I wonder if we should start keeping a list of breaking changes somewhere for release notes. 🤔

@xStrom
Copy link
Member

xStrom commented Apr 10, 2020

Yeah I think it might be a good idea to start a CHANGELOG.md which gets modified with PRs. Every PR can then add a short description of its change to the changelog with a link to the PR. Changes can be grouped by e.g. breaking changes/new features/bug fixes. Generally would be pretty easy to gather the changelog this way. The only somewhat tricky thing is that whenever some behavior gets reverted or modified and there hasn't been a druid release yet, then this revert/modify PR should also remove the older changelog entry.

@cmyr cmyr added the breaking change pull request breaks user code label Apr 10, 2020
@cmyr
Copy link
Member

cmyr commented Apr 10, 2020

for now i'm going to use a label for breaking changes, which will solve one of my problems.

cmyr
cmyr approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is good, and this is a good time to get these changes in.

@cmyr cmyr merged commit bb2d147 into linebender:master Apr 10, 2020
@teddemunnik teddemunnik deleted the rename_mousemoved branch May 9, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom left review comments

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
breaking change pull request breaks user code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teddemunnik @cmyr @xStrom